HeartSaVioR commented on code in PR #45038: URL: https://github.com/apache/spark/pull/45038#discussion_r1487249005
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ValueStateImpl.scala: ########## @@ -54,18 +56,15 @@ class ValueStateImpl[S]( throw StateStoreErrors.implicitKeyNotFound(stateName) } - val toRow = keyExprEnc.createSerializer() - val keyByteArr = toRow + val keyByteArr = keyExprEnc.createSerializer() Review Comment: nit: sorry for missing in initial review - this seems to be also something we can move out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org