mitkedb commented on code in PR #45216: URL: https://github.com/apache/spark/pull/45216#discussion_r1499331276
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ########## @@ -586,9 +584,17 @@ object ContainsExpressionBuilder extends StringBinaryPredicateExpressionBuilderB } case class Contains(left: Expression, right: Expression) extends StringPredicate { - override def compare(l: UTF8String, r: UTF8String): Boolean = l.contains(r) + override def compare(l: UTF8String, r: UTF8String): Boolean = { + val collationID = right.dataType.asInstanceOf[StringType].collationId Review Comment: At the minimum, the codegen code for UTF8 binary should be identical before / after our collation changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org