uros-db commented on code in PR #45216: URL: https://github.com/apache/spark/pull/45216#discussion_r1502735262
########## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ########## @@ -66,6 +66,13 @@ public static class Collation { */ public final boolean isBinaryCollation; + /** + * Built-in string functions with collation support. Review Comment: Update: as agreed in another comment thread, routing is now partially moved over to UTF8String, while binary collations are resolved right away in Scala in order to prevent performance regression -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org