anton5798 commented on PR #45133: URL: https://github.com/apache/spark/pull/45133#issuecomment-1964774548
@jchen5 I considered the two other suggested approaches. I agree that performance-wise both are probably better, although it doesn't seem critical. However, I couldn't yet get a quick clean implementation; I propose to merge as for now. I've created a ticket to further look into it: https://issues.apache.org/jira/browse/SPARK-47171 @cloud-fan could please take a look at this PR? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
