anton5798 commented on PR #45133:
URL: https://github.com/apache/spark/pull/45133#issuecomment-1965406873

   UPD: the current proposed approach actually looks incorrect to me. It fails 
for queries like (adds extra group by condition, and thus returns 2 rows):
   
   ```
   SELECT
     sum(salary),
     sum(salary) FILTER (WHERE EXISTS (SELECT 1
                                       FROM   dept
                                       WHERE  emp.dept_id = dept.dept_id))
   FROM   emp;
   ```
   
   Will work on fixing this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to