stefankandic commented on code in PR #45290: URL: https://github.com/apache/spark/pull/45290#discussion_r1504680132
########## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ########## @@ -183,6 +186,57 @@ class CollationSuite extends DatasourceV2SQLBase { } } + test("aggregates count respects collation") { Review Comment: maybe we should also test struct columns with collations inside -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org