dbatomic commented on code in PR #45290:
URL: https://github.com/apache/spark/pull/45290#discussion_r1506258459
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala:
##########
@@ -353,9 +353,20 @@ object MergeScalarSubqueries extends Rule[LogicalPlan] {
case a: AggregateExpression => a
})
}
+ val groupByExpressionSeq = Seq(newPlan, cachedPlan).map { plan =>
+ plan.groupingExpressions.flatMap(_.collect {
Review Comment:
Added test please take a look.
I also added string with collation to `dsl/package` since that was a natural
way to enable the optimizer tests and i guess that we need this anyhow,
although this is not strictly related to aggs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
