dbatomic commented on code in PR #45290:
URL: https://github.com/apache/spark/pull/45290#discussion_r1507732131
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashMapGenerator.scala:
##########
@@ -173,7 +173,10 @@ abstract class HashMapGenerator(
${hashBytes(bytes)}
"""
}
- case _: StringType => hashBytes(s"$input.getBytes()")
+ case StringType => hashBytes(s"$input.getBytes()")
+ case st: StringType =>
+ hashLong(s"CollationFactory.fetchCollation(${st.collationId})" +
Review Comment:
It is. The thing is that we are still going to use HashAgg for binary
collations (e.g. UNICODE_CI which is also covered by tests). We need to do
proper hashing in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
