cloud-fan commented on code in PR #45150:
URL: https://github.com/apache/spark/pull/45150#discussion_r1541300899
##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -435,6 +438,16 @@ message ExecutePlanResponse {
// the execution is complete. If the server sends onComplete without
sending a ResultComplete,
// it means that there is more, and the client should use ReattachExecute
RPC to continue.
}
+
+ // This message is used to communicate progress about the query progress
during the execution.
+ message ExecutionProgress {
+ int64 num_tasks = 1;
+ int64 num_completed_tasks = 2;
Review Comment:
This looks a bit different from what we have in classic Spark now. Classic
Spark refreshes the progress bar after one stage is finished. So people may see
something like below at the beginning
```
[Stage 1:=================================> (6619 + 12) /
10000]
```
then after stage 1 is completed, the progress bar is refreshed
```
[Stage 2:=====================> (3214 + 12) /
8000]
```
We don't have to follow the exact display format, but this "stage by stage"
approach is more nature fit of the actual query execution in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
