grundprinzip commented on code in PR #45150:
URL: https://github.com/apache/spark/pull/45150#discussion_r1541346247
##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -435,6 +438,16 @@ message ExecutePlanResponse {
// the execution is complete. If the server sends onComplete without
sending a ResultComplete,
// it means that there is more, and the client should use ReattachExecute
RPC to continue.
}
+
+ // This message is used to communicate progress about the query progress
during the execution.
+ message ExecutionProgress {
+ int64 num_tasks = 1;
+ int64 num_completed_tasks = 2;
Review Comment:
I think you're overindexing on accuracy. The progress bar is an ephemeral
piece that simply gives the user feedback about the current operations
happening. This is true for the current progress bar as well it shows a current
stage and will delete it when it gets canceled.
To the user, it does not matter if the percentage is accurate or not as long
as it converges toward 100% at some point in time. Simply seeing that any
progress is happening and the concurrency of it is a benefit to the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
