itholic commented on code in PR #45377:
URL: https://github.com/apache/spark/pull/45377#discussion_r1557621216
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/trees/QueryContexts.scala:
##########
@@ -134,7 +134,9 @@ case class SQLQueryContext(
override def callSite: String = throw SparkUnsupportedOperationException()
}
-case class DataFrameQueryContext(stackTrace: Seq[StackTraceElement]) extends
QueryContext {
+case class DataFrameQueryContext(
+ stackTrace: Seq[StackTraceElement],
+ pysparkLoggingInfo: Option[java.util.Map[String, String]]) extends
QueryContext {
Review Comment:
Because we're currently using `dict` for PySpark logging info and it
internally converted into `Map` from `Py4J`:
```python
logging_info = {
"fragment": name,
"callSite": f"{frame_info.filename}:{frame_info.lineno}",
}
```
Maybe is there happen to any reason that we should use `Option[(String,
String)]`??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
