itholic commented on code in PR #45377:
URL: https://github.com/apache/spark/pull/45377#discussion_r1558758511
##########
sql/core/src/main/scala/org/apache/spark/sql/package.scala:
##########
@@ -111,6 +111,26 @@ package object sql {
}
}
+ private[sql] def withOrigin[T](
+ pysparkLoggingInfo: Option[java.util.Map[String, String]] = None)(f: =>
T): T = {
+ if (CurrentOrigin.get.stackTrace.isDefined) {
+ f
+ } else {
+ val st = Thread.currentThread().getStackTrace
Review Comment:
Maybe can we keep the Java stacktrace as it is?
In PySpark we also provide users an option pysparkJVMStacktraceEnabled to
turn Java stacktrace on or off, since maybe someone still wants to see the Java
stacktrace for deeper debugging?
WDYT, @HyukjinKwon ?
##########
sql/core/src/main/scala/org/apache/spark/sql/package.scala:
##########
@@ -111,6 +111,26 @@ package object sql {
}
}
+ private[sql] def withOrigin[T](
+ pysparkLoggingInfo: Option[java.util.Map[String, String]] = None)(f: =>
T): T = {
+ if (CurrentOrigin.get.stackTrace.isDefined) {
+ f
+ } else {
+ val st = Thread.currentThread().getStackTrace
Review Comment:
Maybe can we keep the Java stacktrace as it is?
In PySpark we also provide users an option `pysparkJVMStacktraceEnabled` to
turn Java stacktrace on or off, since maybe someone still wants to see the Java
stacktrace for deeper debugging?
WDYT, @HyukjinKwon ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
