hvanhovell commented on code in PR #45701: URL: https://github.com/apache/spark/pull/45701#discussion_r1557935463
########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala: ########## @@ -3397,7 +3488,11 @@ class Dataset[T] private[sql] ( sparkSession.analyze(plan, proto.AnalyzePlanRequest.AnalyzeCase.SCHEMA) } - def collectResult(): SparkResult[T] = sparkSession.execute(plan, agnosticEncoder) + def collectResult(): SparkResult[T] = + sparkSession.execute(plan, agnosticEncoder, getObservationsMapOpt) + + def collectObservations(): Map[String, Map[String, Any]] = + collectResult().getObservedMetrics Review Comment: Where are we using this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org