xupefei commented on code in PR #45701:
URL: https://github.com/apache/spark/pull/45701#discussion_r1561082565
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -131,13 +131,25 @@ import org.apache.spark.util.SparkClassUtils
class Dataset[T] private[sql] (
val sparkSession: SparkSession,
@DeveloperApi val plan: proto.Plan,
- val encoder: Encoder[T])
+ val encoder: Encoder[T],
+ @DeveloperApi carryOverObservationsOpt: Option[Map[String, Observation]] =
None)
Review Comment:
Refactor done in the latest comments. I took your suggestion and made a
change to store a map of Plan-Id-to-Observation in SparkSession.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
