cloud-fan commented on code in PR #45377:
URL: https://github.com/apache/spark/pull/45377#discussion_r1558919561
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/trees/QueryContexts.scala:
##########
@@ -134,7 +134,9 @@ case class SQLQueryContext(
override def callSite: String = throw SparkUnsupportedOperationException()
}
-case class DataFrameQueryContext(stackTrace: Seq[StackTraceElement]) extends
QueryContext {
+case class DataFrameQueryContext(
+ stackTrace: Seq[StackTraceElement],
+ pysparkLoggingInfo: Option[(String, String)]) extends QueryContext {
Review Comment:
logging info sounds a bit weird, how about `pysparkErrorCotext`?
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/trees/origin.scala:
##########
@@ -32,10 +32,11 @@ case class Origin(
sqlText: Option[String] = None,
objectType: Option[String] = None,
objectName: Option[String] = None,
- stackTrace: Option[Array[StackTraceElement]] = None) {
+ stackTrace: Option[Array[StackTraceElement]] = None,
+ pysparkLoggingInfo: Option[(String, String)] = None) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
