dongjoon-hyun commented on code in PR #45983:
URL: https://github.com/apache/spark/pull/45983#discussion_r1559881657


##########
project/SparkBuild.scala:
##########
@@ -311,6 +311,7 @@ object SparkBuild extends PomBuild {
 
     (Compile / javacOptions) ++= Seq(
       "-encoding", UTF_8.name(),
+      "-g",

Review Comment:
   This looks safe to me. BTW, we still have differences, don't we?
   > SBT does not have this behavior by default, which leads to some 
differences between the jars of maven and sbt builds, 
   
   The file size seems to be increased from 386053 to 387076 with this, but 
it's still smaller than Maven-generated size, `397996`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to