dongjoon-hyun commented on code in PR #45983:
URL: https://github.com/apache/spark/pull/45983#discussion_r1559891702
##########
project/SparkBuild.scala:
##########
@@ -311,6 +311,7 @@ object SparkBuild extends PomBuild {
(Compile / javacOptions) ++= Seq(
"-encoding", UTF_8.name(),
+ "-g",
Review Comment:
BTW, this is bigger than the PR title.
> Preserve parameter information when using SBT package jar
1. If this is only for parameter info, `-parameters` might be better.
2. However, to be consistent Maven, `-g` is correct.
Given (2), I guess we need to revise the PR title, @cxzl25 .
##########
project/SparkBuild.scala:
##########
@@ -311,6 +311,7 @@ object SparkBuild extends PomBuild {
(Compile / javacOptions) ++= Seq(
"-encoding", UTF_8.name(),
+ "-g",
Review Comment:
BTW, this is bigger than the PR title's scope
> Preserve parameter information when using SBT package jar
1. If this is only for parameter info, `-parameters` might be better.
2. However, to be consistent Maven, `-g` is correct.
Given (2), I guess we need to revise the PR title, @cxzl25 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
