zml1206 opened a new pull request, #45999: URL: https://github.com/apache/spark/pull/45999
### What changes were proposed in this pull request? Replaces `t1.id is null and t2.id is null or t1.id = t2.id` to `t1.id <=> t2.id` in join condition. ### Why are the changes needed? Improve performance. `t1.id is null and t2.id is null or t1.id = t2.id` and `t1.id <=> t2.id` are equivalent in join condition, but the plan will be different and the performance during execution will be completely different. Id is join key in `t1.id <=> t2.id`, in `t1.id is null and t2.id is null or t1.id = t2.id` id cannot be used as join key, this will affect join selection and subsequent matching logic. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit test. ### Was this patch authored or co-authored using generative AI tooling? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
