anton5798 commented on code in PR #45999: URL: https://github.com/apache/spark/pull/45999#discussion_r1568012332
########## sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala: ########## @@ -621,4 +621,14 @@ class DataFrameJoinSuite extends QueryTest checkAnswer(joined, Row("x", null, null)) checkAnswer(joined.filter($"new".isNull), Row("x", null, null)) } + + test("SPARK-47810: replace equivalent expression to <=> in join condition") { Review Comment: Let's also add a summary of plan change (before/after) and quantified performance benefit in the PR description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org