wForget commented on code in PR #45589:
URL: https://github.com/apache/spark/pull/45589#discussion_r1561935953
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala:
##########
@@ -187,57 +187,57 @@ class V2ExpressionBuilder(e: Expression, isPredicate:
Boolean = false) {
assert(v.isInstanceOf[V2Predicate])
new V2Not(v.asInstanceOf[V2Predicate])
}
- case UnaryMinus(child, true) => generateExpressionWithName("-", Seq(child))
- case BitwiseNot(child) => generateExpressionWithName("~", Seq(child))
- case CaseWhen(branches, elseValue) =>
+ case unaryMinus @ UnaryMinus(_, true) =>
+ generateExpressionWithName("-", unaryMinus, isPredicate)
+ case _: BitwiseNot => generateExpressionWithName("~", expr, isPredicate)
+ case caseWhen @ CaseWhen(branches, elseValue) =>
val conditions = branches.map(_._1).flatMap(generateExpression(_, true))
Review Comment:
I reserved `isPredicate=true` for conditions of casewhen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
