cloud-fan commented on code in PR #45589:
URL: https://github.com/apache/spark/pull/45589#discussion_r1562098979
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala:
##########
@@ -98,45 +98,45 @@ class V2ExpressionBuilder(e: Expression, isPredicate:
Boolean = false) {
generateExpression(child).map(v => new V2Cast(v, dataType))
case AggregateExpression(aggregateFunction, Complete, isDistinct, None, _)
=>
generateAggregateFunc(aggregateFunction, isDistinct)
- case Abs(child, true) => generateExpressionWithName("ABS", Seq(child))
- case Coalesce(children) => generateExpressionWithName("COALESCE", children)
- case Greatest(children) => generateExpressionWithName("GREATEST", children)
- case Least(children) => generateExpressionWithName("LEAST", children)
- case Rand(child, hideSeed) =>
+ case abs @ Abs(_, true) => generateExpressionWithName("ABS", abs,
isPredicate)
Review Comment:
We don't need to pass the `isPredicate` parameter, as it's a class member
variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
