hvanhovell commented on code in PR #45701: URL: https://github.com/apache/spark/pull/45701#discussion_r1566169201
########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Observation.scala: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import java.util.UUID + +class Observation(name: String) extends ObservationBase(name) { + + /** + * Create an Observation instance without providing a name. This generates a random name. + */ + def this() = this(UUID.randomUUID().toString) + + @volatile private var planId: Option[(SparkSession, Long)] = None + + private[sql] def register(sparkSession: SparkSession, planId: Long): Unit = { + // makes this class thread-safe: + // only the first thread entering this block can set sparkSession + // all other threads will see the exception, as it is only allowed to do this once + synchronized { + if (this.planId.isDefined) { + throw new IllegalArgumentException("An Observation can be used with a Dataset only once") + } + this.planId = Some((sparkSession, planId)) + } + + sparkSession.observationRegistry.put(planId, this) + } + + private def unregister(): Unit = { Review Comment: How about we move this into the SparkSession? It is a bit weird that we are manipulating state here. I would just make that part of the invoke and remove logic we need to implement anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
