amaliujia commented on code in PR #45931:
URL: https://github.com/apache/spark/pull/45931#discussion_r1566291325
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala:
##########
@@ -358,7 +358,9 @@ case class TakeOrderedAndProjectExec(
val orderByString = truncatedString(sortOrder, "[", ",", "]", maxFields)
val outputString = truncatedString(output, "[", ",", "]", maxFields)
- s"TakeOrderedAndProject(limit=$limit, orderBy=$orderByString,
output=$outputString)"
+ val offsetStr = if (offset > 0) { s" offset=$offset, " } else { "" }
Review Comment:
I assume we only need to skip when offset = 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
