guixiaowen commented on code in PR #45931:
URL: https://github.com/apache/spark/pull/45931#discussion_r1567204208
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala:
##########
@@ -358,7 +358,8 @@ case class TakeOrderedAndProjectExec(
val orderByString = truncatedString(sortOrder, "[", ",", "]", maxFields)
val outputString = truncatedString(output, "[", ",", "]", maxFields)
- s"TakeOrderedAndProject(limit=$limit, orderBy=$orderByString,
output=$outputString)"
+ val offsetStr = if (offset == 0) { "" } else { s" offset=$offset," }
Review Comment:
> How about `val offsetStr = if (offset > 0) s" offset=$offset," else ""` ?
@beliefer Thank you for your review. I made the modifications according to
what you said, but there are some UTs that cannot run through. Can you help me
take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
