ianmcook commented on code in PR #46529:
URL: https://github.com/apache/spark/pull/46529#discussion_r1597327784


##########
python/pyspark/sql/pandas/conversion.py:
##########
@@ -360,42 +361,52 @@ def createDataFrame(  # type: ignore[misc]
 
         assert isinstance(self, SparkSession)
 

Review Comment:
   The git diff makes it difficult to see what I did here. I moved a few lines 
around at the top of this function and added conditional blocks below:
   
   ```py
   if type(data).__name__ == 'Table':
     # new code here to handle PyArrow Table
   else:
     # existing code here to handle PandasDataFrameLike
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to