amol- commented on code in PR #46529: URL: https://github.com/apache/spark/pull/46529#discussion_r1598711077
########## python/pyspark/sql/session.py: ########## @@ -1251,7 +1252,7 @@ def _getActiveSessionOrCreate(**static_conf: Any) -> "SparkSession": spark = builder.getOrCreate() return spark - @overload + @overload # type: ignore[override] Review Comment: Are you sure this isn't due to the fact that the provided overload doesn't have the `schema` argument? Overriding a method while adding or removing arguments will generally trigger an error in mypy (which override does mute) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org