stefankandic commented on code in PR #46280:
URL: https://github.com/apache/spark/pull/46280#discussion_r1601765377
##########
sql/api/src/main/scala/org/apache/spark/sql/types/DataType.scala:
##########
@@ -208,22 +206,33 @@ object DataType {
}
// NOTE: Map fields must be sorted in alphabetical order to keep consistent
with the Python side.
- private[sql] def parseDataType(json: JValue): DataType = json match {
+ private[sql] def parseDataType(
+ json: JValue,
+ fieldPath: String = "",
Review Comment:
there can be no ambiguity with the dots in the names, string or a list
doesn't make any difference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
