stefankandic commented on code in PR #46280:
URL: https://github.com/apache/spark/pull/46280#discussion_r1601767087
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/types/StructTypeSuite.scala:
##########
@@ -606,4 +612,181 @@ class StructTypeSuite extends SparkFunSuite with
SQLHelper {
"b STRING NOT NULL,c STRING COMMENT 'nullable comment'")
assert(fromDDL(struct.toDDL) === struct)
}
+
+ test("simple struct with collations to json") {
+ val simpleStruct = StructType(
+ StructField("c1", StringType(UNICODE_COLLATION)) :: Nil)
+
+ val expectedJson =
+ s"""
+ |{
+ | "type": "struct",
+ | "fields": [
+ | {
+ | "name": "c1",
Review Comment:
there are already tests with dots in `DataTypeSuite` because we care about
deserialization there as well so that's why I didn't put them here. I also
added there tests for case sensitivity and special characters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
