mihailom-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1603210909
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala:
##########
@@ -2938,20 +2940,20 @@ case class Extract(field: Expression, source:
Expression, replacement: Expressio
object Extract {
def createExpr(funcName: String, field: Expression, source: Expression):
Expression = {
// both string and null literals are allowed.
- if ((field.dataType == StringType || field.dataType == NullType) &&
field.foldable) {
- val fieldStr = field.eval().asInstanceOf[UTF8String]
Review Comment:
You do not need to change this here to pattern match, you can use
`field.dataType.isInstanceOf[StringType]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
