uros-db commented on code in PR #46618: URL: https://github.com/apache/spark/pull/46618#discussion_r1604614789
########## sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala: ########## @@ -1584,6 +1584,234 @@ class CollationSQLExpressionsSuite }) } + test("CurrentTimeZone expression with collation") { + // Supported collations + Seq("UTF8_BINARY", "UTF8_BINARY_LCASE", "UNICODE", "UNICODE_CI").foreach(collationName => { Review Comment: since we're now using this `Seq("UTF8_BINARY", "UTF8_BINARY_LCASE", "UNICODE", "UNICODE_CI")` a lot, let's separate it out and call it something like `testCollationsSeq` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org