dbatomic commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1604648152
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -768,7 +768,7 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanHelper {
})
}
- test("hash based joins not allowed for non-binary collated strings") {
+ test("hash based joins are also allowed for non-binary collated strings") {
Review Comment:
Feel free to remove this test if `hash join should be used for collated
strings` is enough.
In tests we shouldn't care about history - i.e. it is not important that
once upon a time we didn't support hash joins and now we do. Tests should just
assert that current behaviour is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
