cloud-fan commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1612585293
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -250,7 +250,8 @@ abstract class Optimizer(catalogManager: CatalogManager)
InsertMapSortInGroupingExpressions) :+
// This batch must be executed after the `RewriteSubquery` batch, which
creates joins.
Batch("NormalizeFloatingNumbers", Once, NormalizeFloatingNumbers) :+
- Batch("ReplaceUpdateFieldsExpression", Once, ReplaceUpdateFieldsExpression)
+ Batch("ReplaceUpdateFieldsExpression", Once,
ReplaceUpdateFieldsExpression) :+
+ Batch("RewriteCollationJoin", Once, RewriteCollationJoin)
Review Comment:
since this enlarges the query plan (adding `CollationKey`), we should do it
as late as possible: the last rule in `SparkOptimizer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
