milastdbx commented on code in PR #46642: URL: https://github.com/apache/spark/pull/46642#discussion_r1606852425
########## connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCPushdownTest.scala: ########## @@ -0,0 +1,387 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package test.scala.org.apache.spark.sql.jdbc.v2 + +import scala.collection.immutable.Seq + +import org.apache.spark.sql.{DataFrame, QueryTest, Row} +import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, LocalLimit} +import org.apache.spark.sql.execution.FilterExec +import org.apache.spark.sql.test.SharedSparkSession +import org.apache.spark.tags.DockerTest + +@DockerTest Review Comment: Why did you put this in docker-integration tests folder ? this seems generic to jdbc ########## sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala: ########## @@ -155,7 +162,8 @@ private case class PostgresDialect() extends JdbcDialect with SQLConfHelper { getJDBCType(et).map(_.databaseTypeDefinition) .orElse(JdbcUtils.getCommonJDBCType(et).map(_.databaseTypeDefinition)) .map(typeName => JdbcType(s"$typeName[]", java.sql.Types.ARRAY)) - case _ => None + case LongType => Some(JdbcType("BIGINT", Types.BIGINT)) + case _ => JdbcUtils.getCommonJDBCType(dt) Review Comment: none code path returns this as well ? ########## connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCPushdownTest.scala: ########## @@ -0,0 +1,387 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package test.scala.org.apache.spark.sql.jdbc.v2 + +import scala.collection.immutable.Seq + +import org.apache.spark.sql.{DataFrame, QueryTest, Row} +import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, LocalLimit} +import org.apache.spark.sql.execution.FilterExec +import org.apache.spark.sql.test.SharedSparkSession +import org.apache.spark.tags.DockerTest + +@DockerTest Review Comment: remove this ########## sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala: ########## @@ -155,7 +162,8 @@ private case class PostgresDialect() extends JdbcDialect with SQLConfHelper { getJDBCType(et).map(_.databaseTypeDefinition) .orElse(JdbcUtils.getCommonJDBCType(et).map(_.databaseTypeDefinition)) .map(typeName => JdbcType(s"$typeName[]", java.sql.Types.ARRAY)) - case _ => None + case LongType => Some(JdbcType("BIGINT", Types.BIGINT)) + case _ => JdbcUtils.getCommonJDBCType(dt) Review Comment: When you return None I mean, `JdbcUtils.getCommonJDBCType` should be called ? ########## sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala: ########## @@ -141,6 +160,9 @@ private case class MsSqlServerDialect() extends JdbcDialect { case ShortType if !SQLConf.get.legacyMsSqlServerNumericMappingEnabled => Some(JdbcType("SMALLINT", java.sql.Types.SMALLINT)) case ByteType => Some(JdbcType("SMALLINT", java.sql.Types.TINYINT)) + case LongType => Some(JdbcType("BIGINT", java.sql.Types.BIGINT)) + case DoubleType => Some(JdbcType("FLOAT", java.sql.Types.FLOAT)) + case _ if !SQLConf.get.legacyMsSqlServerNumericMappingEnabled => JdbcUtils.getCommonJDBCType(dt) Review Comment: why this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
