uros-db commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1612779931
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -279,6 +280,7 @@ abstract class Optimizer(catalogManager: CatalogManager)
RewritePredicateSubquery.ruleName ::
NormalizeFloatingNumbers.ruleName ::
ReplaceUpdateFieldsExpression.ruleName ::
+ RewriteCollationJoin.ruleName ::
Review Comment:
@cloud-fan should `RewriteCollationJoin` be a nonExcludable rule or not -
not sure what's the convention here? since there is essentially no impact on
correctness, I think we may remove it from `nonExcludableRules`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
