davidm-db commented on code in PR #46665:
URL: https://github.com/apache/spark/pull/46665#discussion_r1613136311
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; }
public boolean double_quoted_identifiers = false;
}
+compoundOrSingleStatement
+ : singleStatement
+ | singleCompound
+ ;
+
+singleCompound
+ : compound SEMICOLON* EOF
+ ;
+
+compound
+ : BEGIN compoundBody END
+ ;
+
+// Last semicolon in body is optional.
+compoundBody
+ : compoundStatement (SEMICOLON+ compoundStatement)* SEMICOLON*
Review Comment:
Not sure why we did it like this in POC, I've tried in MySql Workbench now
and it seems that MySql doesn't allow multiple "empty" semicolons... I'll need
to check what is the desired behavior and will update accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
