davidm-db commented on code in PR #46665:
URL: https://github.com/apache/spark/pull/46665#discussion_r1613161561
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; }
public boolean double_quoted_identifiers = false;
}
+compoundOrSingleStatement
+ : singleStatement
+ | singleCompound
+ ;
+
+singleCompound
+ : compound SEMICOLON* EOF
+ ;
+
+compound
+ : BEGIN compoundBody END
+ ;
+
+// Last semicolon in body is optional.
+compoundBody
Review Comment:
As Milan said, we will reuse `compoundBody` in future in the blocks that
don't require `BEGIN` and `END` (if else, while, etc.).
One more reason is that in such blocks (that don't begin with `BEGIN`)
variable declaration is not allowed, so it is easier to have these cases
separated for the sake of additional checks in visitor functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
