wayneguow commented on code in PR #46731:
URL: https://github.com/apache/spark/pull/46731#discussion_r1613124606
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -90,8 +91,8 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
table.schema.findNestedField(Seq(colName), resolver = conf.resolver)
.map(_._2.dataType)
.getOrElse {
- throw
QueryCompilationErrors.alterColumnCannotFindColumnInV1TableError(
- quoteIfNeeded(colName), table)
+ throw QueryCompilationErrors.unresolvedColumnError(
Review Comment:
> Can we reuse `UNRESOLVED_COLUMN.WITH_SUGGESTION`?
For the scenario of `ALTER COLUMN`, since there is one table, I think it is
OK; for `resolveFieldNames` in `Analyzer`, I think it would be better if the
table can be explicitly specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
