LuciferYang commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1616641862
########## sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTableTests.scala: ########## @@ -432,11 +432,23 @@ trait AlterTableTests extends SharedSparkSession with QueryErrorsBase { withTable(t) { sql(s"CREATE TABLE $t (id int) USING $v2Format") - val exc = intercept[AnalysisException] { - sql(s"ALTER TABLE $t ADD COLUMN point.z double") - } - - assert(exc.getMessage.contains("Missing field point")) + val sqlText = s"ALTER TABLE $t ADD COLUMN point.z double" Review Comment: The error message obtained by executing this SQL is: ``` A column, variable, or function parameter with name `point` cannot be resolved. Did you mean one of the following in table `testcat`.`ns1`.`ns2`.`table_name`? [`id`] ``` This seems a bit strange, is it suggesting that users should change to execute ``` ALTER TABLE $t ADD COLUMN id.z double ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org