Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/6405#discussion_r31389663 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCheckResult.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +/** + * Represents the result of `Expression.checkInputDataTypes`. + * We will throw `AnalysisException` in `CheckAnalysis` if error message is not null. + * Use [[TypeCheckResult.success]] and [[TypeCheckResult.fail]] to instantiate this. + * + */ +class TypeCheckResult private (val errorMessage: String) extends AnyVal { + def hasError: Boolean = errorMessage != null +} + +object TypeCheckResult { + val success: TypeCheckResult = new TypeCheckResult(null) + def fail(msg: String): TypeCheckResult = new TypeCheckResult(msg) +} --- End diff -- I'm thinking something about this: ```scala trait TypeCheckResult { def isFailure: Boolean def isSuccess: Boolean } object TypeCheckResult { object Success extends TypeCheckResult { override def isFailure: Boolean = false override def isSuccess: Boolean = true } case class Failure(message: String) extends TypeCheckResult { override def isFailure: Boolean = true override def isSuccess: Boolean = false } } ``` One potential benefit is that now you can check `TypeCheckResult` within a pattern match.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org