Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6405#discussion_r31394776
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -125,7 +133,13 @@ case class GroupExpression(children: Seq[Expression])
extends Expression {
* so that the proper type conversions can be performed in the analyzer.
*/
trait ExpectsInputTypes {
+ self: Expression =>
def expectedChildTypes: Seq[DataType]
+ override def checkInputDataTypes: TypeCheckResult = {
+ // We will always do type casting for `ExpectsInputTypes` in
`HiveTypeCoercion`,
+ // so type mismatch error won't be reported here, but for underling
`Cast`s.
--- End diff --
Seems this will result in a confusing error, since it will complain about
casts that the user does not see in their query.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
