cloud-fan commented on code in PR #47105: URL: https://github.com/apache/spark/pull/47105#discussion_r1663675449
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/linearRegression.scala: ########## @@ -311,7 +312,8 @@ case class RegrIntercept(left: Expression, right: Expression) extends Declarativ private val covarPop = new CovPopulation(right, left) - private val varPop = new VariancePop(right) + private val varPop = new VariancePop(If(And(IsNotNull(left), IsNotNull(right)), Review Comment: instead of adding null check to the underlying `VariancePop`, shall we add it to `RegrIntercept`? e.g. we can add null check to `updateExpressions`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
