wayneguow commented on code in PR #47105:
URL: https://github.com/apache/spark/pull/47105#discussion_r1664165273
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/linearRegression.scala:
##########
@@ -311,7 +312,8 @@ case class RegrIntercept(left: Expression, right:
Expression) extends Declarativ
private val covarPop = new CovPopulation(right, left)
- private val varPop = new VariancePop(right)
+ private val varPop = new VariancePop(If(And(IsNotNull(left),
IsNotNull(right)),
Review Comment:
I tried changing it locally and related test cases passed. It seems that the
logic is more complicated. Is it worth updating like this? WDYT @cloud-fan
```
override lazy val updateExpressions: Seq[Expression] = {
val isNull = left.isNull || right.isNull
val updateResult = covarPop.updateExpressions ++ varPop.updateExpressions
aggBufferAttributes.zip(updateResult).map { case (oldValue, newValue) =>
If(isNull, oldValue, newValue)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
