cloud-fan commented on code in PR #47180: URL: https://github.com/apache/spark/pull/47180#discussion_r1665336355
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveIdentifierClause.scala: ########## @@ -44,8 +46,10 @@ class ResolveIdentifierClause(earlyBatches: Seq[RuleExecutor[LogicalPlan]#Batch] e.exprBuilder.apply(evalIdentifierExpr(e.identifierExpr), e.otherExprs) } } +} - private def evalIdentifierExpr(expr: Expression): Seq[String] = { +object ResolveIdentifierClause extends AliasHelper { Review Comment: do we still need this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org