cloud-fan commented on code in PR #47180:
URL: https://github.com/apache/spark/pull/47180#discussion_r1668293122
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1796,6 +1796,9 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
case s: Sort if !s.resolved || s.missingInput.nonEmpty =>
resolveReferencesInSort(s)
+ case u: UnresolvedWithCTERelations =>
Review Comment:
Thinking about it more, now we need to special-case
`UnresolvedWithCTERelations` twice: once in `ResolveReferences` to resolve
session variables and once in `ResolveIdentifierClause` to resolve identifier
and look up CTE relations.
How about we make `UnresolvedWithCTERelations` an unary code, and only
special case it once in `ResolveRelations` that we should look up from CTE
relations for `UnresolvedRelations` inside`UnresolvedWithCTERelations`? Sorry
for the back and forth!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
