stefankandic commented on code in PR #47226: URL: https://github.com/apache/spark/pull/47226#discussion_r1666766006
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collationExpressions.scala: ########## @@ -38,8 +38,8 @@ import org.apache.spark.sql.types._ Examples: > SET spark.sql.collation.enabled=true; spark.sql.collation.enabled true - > SELECT COLLATION('Spark SQL' _FUNC_ UTF8_LCASE); - UTF8_LCASE + > SELECT _FUNC_('Spark SQL', 'UTF8_LCASE'); + spark sql Review Comment: ```suggestion Spark SQL ``` Collating a string to lowercase collation does not mean to convert it to lowercase characters. Lowercase collation just means that strings will be compared as equal if their lowercase variants are the same, but the string representation does not change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org