nebojsa-db commented on code in PR #47180: URL: https://github.com/apache/spark/pull/47180#discussion_r1669215813
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ########## @@ -1796,6 +1796,9 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor case s: Sort if !s.resolved || s.missingInput.nonEmpty => resolveReferencesInSort(s) + case u: UnresolvedWithCTERelations => Review Comment: No worry! Hm, issue with that approach is that `ResolveRelations` is traversing the tree in bottom up manner so we will first do table lookup instead of CTE relations lookup since it will first encounter `UnresolvedRelation` instead of `UnresolvedWithCTERelations`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org