panbingkun commented on code in PR #47293:
URL: https://github.com/apache/spark/pull/47293#discussion_r1673856018
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala:
##########
@@ -442,16 +441,16 @@ class HiveQuerySuite extends HiveComparisonTest with
SQLTestUtils with BeforeAnd
val expected = sql("SELECT key FROM small_src").collect().head
val res = sql(
"""
- |SELECT TRANSFORM (key) ROW FORMAT SERDE
- |'org.apache.hadoop.hive.serde2.avro.AvroSerDe'
- |WITH SERDEPROPERTIES ('avro.schema.literal'='{"namespace":
- |"testing.hive.avro.serde","name": "src","type": "record","fields":
- |[{"name":"key","type":"int"}]}') USING 'cat' AS (tKey INT) ROW FORMAT
SERDE
- |'org.apache.hadoop.hive.serde2.avro.AvroSerDe' WITH SERDEPROPERTIES
- |('avro.schema.literal'='{"namespace":
"testing.hive.avro.serde","name":
- |"src","type": "record","fields": [{"name":"key","type":"int"}]}')
- |FROM small_src
- """.stripMargin.replaceAll(System.lineSeparator(), " ")).collect().head
+ |SELECT TRANSFORM (key) ROW FORMAT SERDE
+ |'org.apache.hadoop.hive.serde2.avro.AvroSerDe'
+ |WITH SERDEPROPERTIES ('avro.schema.literal'='{"namespace":
+ |"testing.hive.avro.serde","name": "src","type": "record","fields":
+ |[{"name":"key","type":"int"}]}') USING 'cat' AS (tKey INT) ROW
FORMAT SERDE
+ |'org.apache.hadoop.hive.serde2.avro.AvroSerDe' WITH SERDEPROPERTIES
+ |('avro.schema.literal'='{"namespace":
"testing.hive.avro.serde","name":
+ |"src","type": "record","fields": [{"name":"key","type":"int"}]}')
+ |FROM small_src
+ """.stripMargin.replaceAll(System.lineSeparator(), " ")).collect().head
Review Comment:
<del>Yeah, the main change is to fix the described in this PR.</del>
No, formatting code is just an incidental behavior, mainly referring to the
three places described in PR
- use `getWorkspaceFilePath` to enable `HiveQuerySuite` to run successfully
in the `IDE`.
- make the test `lookup hive UDF in another thread` independence, without
relying on the previous UT `current_database with multiple sessions`.
- enable two test: `non-boolean conditions in a CaseWhen are illegal` and
`Dynamic partition folder layout`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
