LuciferYang commented on code in PR #47293:
URL: https://github.com/apache/spark/pull/47293#discussion_r1675341793
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala:
##########
@@ -1288,7 +1303,7 @@ class HiveQuerySuite extends HiveComparisonTest with
SQLTestUtils with BeforeAnd
assertResult(1, "Duplicated project detected\n" + analyzedPlan) {
analyzedPlan.collect {
- case i: InsertIntoHiveTable => i.query.collect { case p: Project => ()
}.size
+ case i: InsertIntoHiveTable => i.query.collect { case _: Project => ()
}.size
Review Comment:
let's revert this change
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala:
##########
@@ -1307,7 +1322,7 @@ class HiveQuerySuite extends HiveComparisonTest with
SQLTestUtils with BeforeAnd
assertResult(2, "Duplicated project detected\n" + analyzedPlan) {
analyzedPlan.collect {
- case i: InsertIntoHiveTable => i.query.collect { case p: Project =>
() }.size
+ case i: InsertIntoHiveTable => i.query.collect { case _: Project =>
() }.size
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
