Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6405#discussion_r31394977
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -86,12 +86,20 @@ abstract class Expression extends TreeNode[Expression] {
case (i1, i2) => i1 == i2
}
}
+
+ /**
+ * Check the input data types, returns `TypeCheckResult.success` if it's
valid,
+ * or return a `TypeCheckResult` with an error message if invalid.
+ * TODO: we should remove the default implementation and implement it
for all
+ * expressions with proper error message.
+ */
+ def checkInputDataTypes(): TypeCheckResult = TypeCheckResult.success
--- End diff --
talked to @marmbrus -- since it is named with a "verb", and might be
expensive, let's keep the parentheses here for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
