davidm-db commented on code in PR #47403: URL: https://github.com/apache/spark/pull/47403#discussion_r1684082230
########## sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala: ########## @@ -146,6 +147,15 @@ abstract class BaseSessionStateBuilder( extensions.buildParser(session, new SparkSqlParser()) } + /** + * Script interpreter that produces execution plan for sql batch procedural language. + * + * Note: this depends on the `conf` field. Review Comment: do we know what this part of the comment actually means? I see that it's being reused around, but not sure what it means exactly... I mean, I don't see that `conf` is used anywhere in `scriptingInterpreter` creation... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org